search

cs-au-dk / Artemis

automated testing for JavaScript
http://www.brics.dk/artemis/
GNU General Public License v3.0
36 stars 10 forks source link

Demo mode crashes on "invalid" URLs. #53

Closed BenSpencer closed 11 years ago

BenSpencer commented 11 years ago

When changing page using the address bar in the new demo mode if you choose an invalid URL then it crashes out immediately. Unfortunately this even includes things like "www.google.com" instead of "http://www.google.com". Need to add some checking and an error message instead of a crash. Possibly also some "guessing" of the intended URL, such as automatically adding "http://" or "www.".

sema commented 11 years ago

We should have a bit of logic already like this as part of the argument parsing logic. We could try to reuse some of this.

See the bottom of the parseCmd function in artemis.cpp

BenSpencer commented 11 years ago

Thanks for the tip... I was hoping there would be something like this.

BenSpencer commented 11 years ago

Hi Casper, Have you made any changes (e.g. to ArtemisWebView) which might have affected this? I was just trying to fix this but can't actually reproduce the problem now.

If not, do you think it could be related to our other strange bugs?

sema commented 11 years ago

I should not have changed anything related to that. The only crash related bug I have fixed was something related to the shutdown sequence of Artemis.

On 20 June 2013 16:53, Ben Spencer notifications@github.com wrote:

Hi Casper, Have you made any changes (e.g. to ArtemisWebView) which might have affected this? I was just trying to fix this but can't actually reproduce the problem now.

If not, do you think it could be related to our other strange bugs?

— Reply to this email directly or view it on GitHubhttps://github.com/cs-au-dk/Artemis/issues/53#issuecomment-19758359 .