cs-discord-at-ucf / lion

🦁A Discord bot from scratch for the UCF Computer Science Discord.
MIT License
42 stars 18 forks source link

Build Lion 3.0 #761

Closed bluffdev closed 1 year ago

bluffdev commented 1 year ago

The problem:

Let’s face it. The current version of Lion is terrible. It doesn’t support slash commands and trying to migrate over to them is not a viable option. This bot NEEDS slash commands since they provide a much better user experience and are also better for user privacy. The bot is also way too bloated and no one wants to work on it. I also find the design of the bot to be a bit too complex.

Here’s my proposal:

We build a new bot with TypeScript that supports slash commands. The goal should be for the bot to be lean, easy to maintain, and have a less complex structure. We should also have stricter guidelines for feature requests to avoid unnecessary dependencies like what we have now.

We only need features related to these categories:

We probably need 4-5 people to work on this (I volunteer to help). The goal should be to have it finished and running in the server by the end of the year for Spring 2024. If we can get it done sooner that would be awesome. Let me know what your thoughts are on this and if there are any specific things that you want to include that I didn’t mention.

tanndlin commented 1 year ago

Most of us maintainers / admins of this repo are not too active in the server anymore, but we wouldn't mind you making pull requests in an attempt to trim fat from the repo (unused jobs/plugins/handlers anything like that), and I would be happy to do code reviews for such PRs.

Trimming fat

Starting new

Appreciate the issue, and wish you luck. I hope you can get some other young people on board to get more involved. Working on an open source project with multiple people is an invaluable experience you will not learn from college classes.

🚀

c650 commented 1 year ago

Migrating to slash really isn’t that hard

you’re welcome to build your own bot but you would then have to convince people ti use it

joeydotdev commented 1 year ago

If your motivation for a rewrite is to support slash commands, it's going to be way more work to rewrite a version with half the parity of what the bot has now than it is to just migrate the current codebase to support slash plugins. Rewrite doesn't make much sense to me.

I don't think I've seen any contributions from you so not sure if calling something super complex is a fair assessment. The codebase has been around for 4 years now, so it's bound to grow larger when handling different feature requests, but the patterns have remained relatively consistent from start of the project to now.

c650 commented 1 year ago

738 and #739 are two early attempts at slash commands

If you’re interested in taking that over, I suggest that you pick up a few smaller issues first

bluffdev commented 1 year ago

@tanndlin can you add me as a contributor and post an updated server template in #lion_project?

tanndlin commented 1 year ago

@tanndlin can you add me as a contributor and post an updated server template in #lion_project?

Invited.

I don't have access to the server template since I'm not an admin anymore. You will have to DM one of them from the server

tanndlin commented 1 year ago

I'm going to close this issue since this is not something the maintainers think is necessary. Feel free to make the same issue on a fork