Time travel is broken

[fenhl]

Looks like the time travel fix to get future Custom Standard rotations working broke the feature in other ways. Details to be investigated.

[taw]

Oh interesting. Time travel has 4 components:

• card release date - that should be straightforward, just stick proper date in set's json file (or per file if it's a weird set like promo cards). Time travel gets really confused when this date is wrong or missing.
• name resolution - if you use time:roe instead of time:2010-15-31 format, it uses that date, easy to support for your own sets
• ban list - that generally shouldn't apply, but banlist format is super friendly (see search-engine/lib/ban_list/brawl.rb for small recent example). It's just list of dates with list of legalities and announcement link (can be nil).
• format rotation - if you inherit from FormatStandard and override rotation_schedule, it should work.

There's no rotation-specific logic anywhere else IIRC.

[taw]

I'd recommend writing specs like search-engine/spec/format_brawl_spec.rb for your custom rotating format.

[fenhl]

Sorry, there's some missing context here. The “fix” I'm referring to is this change, intent being that cards with a future release date are not shown by default; you'd have to use time travel if you want to look at future rotations. It works well for that purpose, but I don't exactly remember what this broke.

[fenhl]

Found it again: the query (time:OGW f:Standard) not (time:SOI f:Standard) works fine on mtg.wtf but is broken on Lore Seeker.

[taw]

Right, the default is to include future cards, so it works in prerelease season. You need explicit time:now or similar to override this.

[fenhl]

That's not the desired bahavior for Lore Seeker though, hence my (broken) change.