search

cs-education / sysbuild

A system programming learning environment in the browser
https://cs-education.github.io/sys/
Other
36 stars 35 forks source link

Prevent users from accidentally navigate the page backward #126

Closed jwchang0206 closed 8 years ago

jwchang0206 commented 8 years ago

When I was taking CS 241, I had this problem. Somehow the focus was out of the ACE editor and pressing backspace key made my browser to go back which was blank chrome tab because I accessed playground through my bookmark . In this case, the whole lines of code would be lost.

I added e.preventDefault() on pressing backspace key on window keydown event.

angrave commented 8 years ago

Great idea. Thank you thank you thank you (from someone who also experienced this unwanted behavior!)

On 11/26/15 6:58 AM, JeongWoo Chang wrote:

When I was taking CS 241, I had this problem. Somehow the focus was out of the ACE editor and pressing backspace key made my browser to go back which was blank chrome tab because I accessed playground through my bookmark . In this case, the whole lines of code would be lost.

I added |e.preventDefault()| on pressing backspace key on |window| keydown event.

— Reply to this email directly or view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cs-2Deducation_sysbuild_issues_126&d=BQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=DvT4PEagC1_uJoK7XYcVznCf9vBnV8AqDdM20MaTLvM&m=p1vLEfNDWIiarurwZCZeDlMPfu1q2QH7t15glJRKdrM&s=bDorlKVWMLXunkFGZ8Z7AsGDJdGyWxHXL9tXPcsPNxw&e=.

neelabhg commented 8 years ago

Thank you for the pull-request. Although accepting at this time is inconvenient because of an ongoing major refactoring, I'm going to merge this in soon, in appreciation of your effort.

Thanks again for contributing!

jwchang0206 commented 8 years ago

ongoing major refactoring? My group (senior project) is working base on the current master branch. So there would be a painful merge conflicts. What should we do about this situation?

neelabhg commented 8 years ago

Ah, I didn't realize you are also in the Senior Projects team. Can you please email me and/or @cmercur2 so that we can discuss this and be on the same page?