cs-education / sysbuild

A system programming learning environment in the browser
https://cs-education.github.io/sys/
Other
36 stars 35 forks source link

local installation fails #171

Closed remisharrock closed 7 years ago

remisharrock commented 8 years ago

Hi, I tried to follow the steps here without success:

1 seems OK:

$ npm --version
3.10.6

2 seems OK:

$ bower --version
1.7.9
$ gulp --version
[17:33:59] CLI version 3.9.1

3 forked and cloned correctly my fork. 4 ok 5 seems ok, but I have three questions: Q1: in script.sh , why do you use https://github.com/s-macke/jor1k.git instead of https://github.com/cs-education/jor1k.git ? Q2: the folder jo1k has a .gitsubmodules with

[submodule "sys"]
    path = sys
    url = https://github.com/s-macke/jor1k-sysroot.git

If I understand correctly the dependencies here , the url should be replaced with https://github.com/cs-education/jor1k/tree/sysbuild-stable ? Q3: should the script.sh also initialize the folder sys ? because it is not initialized after step 5 6 ok 7 a few warnings:

npm WARN deprecated gulp-minify-css@1.2.4: Please use gulp-clean-css
npm WARN deprecated phantomjs@2.1.7: Package renamed to phantomjs-prebuilt. Please update 'phantomjs' package references to 'phantomjs-prebuilt'
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated lodash@1.0.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN prefer global node-gyp@3.4.0 should be installed with -g
npm WARN eslint-config-airbnb@9.0.1 requires a peer of eslint-plugin-jsx-a11y@^1.2.0 but none was installed.
npm WARN eslint-config-airbnb@9.0.1 requires a peer of eslint-plugin-react@^5.0.1 but none was installed.

8 here I got an error:

$ gulp serve
[18:09:27] Failed to load external module babel-register
[18:09:27] Requiring external module babel-core/register
[18:09:35] Using gulpfile ~/sysbuild/webapp/gulpfile.babel.js
[18:09:35] Starting 'css:src'...
[18:09:36] Finished 'css:src' after 1.28 s
[18:09:36] Starting 'css:watch'...
[18:09:36] Finished 'css:watch' after 15 ms
[18:09:36] Starting 'serve:src'...
[18:09:37] Finished 'serve:src' after 108 ms
[18:09:37] Starting 'serve'...
[18:09:37] Finished 'serve' after 7.85 μs
[18:09:37] Server started http://localhost:8080

when I search for "Failed to load external module babel-register" I might be related to https://github.com/google/web-starter-kit/issues/878 https://github.com/yeoman/generator-webapp/issues/356 9 blank page with this console output:

GET http://localhost:8080/app/ga-tracker.js net::ERR_BLOCKED_BY_CLIENT
Uncaught Error: Script error for "app/ga-tracker"
http://requirejs.org/docs/errors.html#scripterror
Uncaught ReferenceError: window is not defined
Error at http://localhost:8080/bower_modules/requirejs/require.js:24: Uncaught ReferenceError: window is not defined
Master: Abort execution.
Uncaught Error: Kill master
remisharrock commented 8 years ago

update: on a clean install of npm etc, I get this message:

$ gulp serve
[02:23:39] Requiring external module babel-register
/Users/Shared/sharrock/sysbuild/webapp/gulpfile.babel.js:1
(function (exports, require, module, __filename, __dirname) { import fs from 'fs';
                                                              ^^^^^^
SyntaxError: Unexpected token import
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:528:28)
    at loader (/Users/Shared/sharrock/sysbuild/webapp/node_modules/babel-register/lib/node.js:146:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/Shared/sharrock/sysbuild/webapp/node_modules/babel-register/lib/node.js:156:7)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Liftoff.handleArguments (/usr/local/lib/node_modules/gulp/bin/gulp.js:116:3)
aadilzbhatti commented 7 years ago

I'll look into this

aadilzbhatti commented 7 years ago

Seems fine to me, except my NPM is 3.8.9. Not sure why that would make a difference. If you're still concerned about this, try downloading a fresh copy of the repo and try again -- I had a lot of similar issues but everything seems to be in order at the moment