search

cs-util-com / cscore

cscore is a minimal-footprint library providing commonly used helpers & patterns for your C# projects. It can be used in both pure C# and Unity projects.
https://cs-util-com.github.io/cscore/
Apache License 2.0
195 stars 32 forks source link

PointerInputHandler.cs onClick issue #74 #75

Closed equidevium closed 2 years ago

equidevium commented 2 years ago

Fix for the PointerInputHandler.cs where onClick was not always detected. Added two useful properties for PointerEventData to be accessible.

This change is Reviewable

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit a58aee2f and detected 0 issues on this pull request.

View more on Code Climate.

cs-util commented 2 years ago

The problem you are describing in https://github.com/cs-util-com/cscore/issues/74 wasn't reproducible in the Ui21_UserInput test scene, which Unity version are you using?

cs-util commented 2 years ago

The changes look good in general, even if I could not reproduce it, I can merge them back after https://github.com/cs-util-com/cscore/pull/75/files#r810460748 is addressed