cs0x7f / cstimer

Professional Speedcubing/Training Timer
GNU General Public License v3.0
566 stars 132 forks source link

Update CIC list to include all possible values for GAN cubes #371

Closed afedotov closed 8 months ago

afedotov commented 8 months ago

Add all possible 256 CIC values for GAN cubes, according to this findings -> https://github.com/cs0x7f/cstimer/pull/370#issuecomment-1963191334

I tested this in the current stable version of Chrome on macOS and Android, and in the Bluefy on iPadOS. Seems like all works fine without issues. We can try to use such approach in the wild and see if any issues pop out, I want to believe should not be any. And it is better to autodetect MAC address in any condition rather than guiding users to unbind cube from account.

Also I've increased timeout for waiting advertising packet when autodetecting MAC address. Some cubes like MoYu AI 2023 has very long advertising interval, and sometimes this timeout is not enough and fired before advertising packet is received from the cube. It is better to wait a bit more rather than giving up early. Increased timeout will not affect responsiveness of cube connection procedure.