search

cs0x7f / cstimer

Professional Speedcubing/Training Timer
GNU General Public License v3.0
551 stars 132 forks source link

Set minimum height for stats panel in mobile view #385

Closed afedotov closed 5 months ago

afedotov commented 5 months ago

In mobile view minimum height for stats panel is not set. When session result set is small, only single result row is displayed. This is very inconvenient. So set minimum height for stats panel that at least 3 rows will be displayed.

Before After
cs0x7f commented 5 months ago

It's by design that only single result row is displayed.

afedotov commented 5 months ago

Hmm, really? I'm curious why? Sometimes I make short sessions for contests that is only 5 solves. And single row displayed is not much handy.

cs0x7f commented 5 months ago

The mobile phone screen is too small, so I made each panel display as little unnecessary information as possible, leaving more space for the timer. For the statistics panel, except for the latest solve, previous solves usually receive much less attention and can be easily scrolled down if necessary.

afedotov commented 5 months ago

Ok, I see. I thought that this panel in either way expands when more lines (ao5, ao12, ao50, ao100) added to average times. So this makes no difference in terms of occupied space, but makes it more handy when resultset is small at the start of the session.

I withdraw this PR. But if you reconsider later, just add this changes.

BTW maybe make this in different way. In average panel always show configured indicators, even if current session result set is not large enough, just display dash like in times table. In such case you instantly can see how much space this indicator configuration will take.