cs0x7f / cstimer

Professional Speedcubing/Training Timer
GNU General Public License v3.0
551 stars 132 forks source link

Add checkbox for confirming deletion #435

Open NorbertCode opened 9 hours ago

NorbertCode commented 9 hours ago

Vivaldi web-apps don't support Javascript pop-up windows. Since csTimer uses them to confirm deletion, it's impossible to delete a time.

A way to solve this problem would be adding a checkbox, which controls whether this pop-up should be shown.

The way I've done it only works when Multiple Deletion is disabled, because Multiple Deletion requires a pop-up to enter how many rows to delete. I'm not sure if this is more intuitive than Confirm Deletion overriding it, so I'm open to suggestions.

From testing on my local machine it looks like everything works, but I'm not sure if it would on a production server.

Also, I couldn't find any contribution guidelines so I only modified options for the English language, so the setting doesn't exist in other ones.