cs136 / seashell

Seashell is an online environment for editing, running, and submitting C programming assignments.
GNU General Public License v3.0
38 stars 19 forks source link

Console/Editor size problem #648

Closed yuliswe closed 7 years ago

yuliswe commented 7 years ago

Seashell seems like it’s hard coded to 1080P regardless of actual window size, so instead of fixing the “above/below” layout (instead of enlarging the console you shrunk the editor, making both unusably small for use during lectures) you have also broken the side-by-side layout. At projector resolution (1024x768) not even the entire editor pane fits on screen anymore!

So here are the issues:

In above/below mode, at the font size I use in class, I get 8 rows in the editor and 7 rows in the console…that’s better than the 2 we had before but well short of the “same height as the editor pane” in the actual feature request. And it shrunk the editor! That’s very very bad.

In side-by-side mode both editor and console panes are sized to fit at 1080P resolution. They used to be sized to fit in the actual window! This also affects above/below, since the total amount of scrolling is identical (and on my 1080P monitor, no scrolling).

Here is the desired behavior:

Side-by-side mode has the editor and console panes be exactly the height they should be so that the main window does not have a scroll bar (like how it was before)

Above/below mode does not touch the editor or console heights at all, it just makes them both full width. This will make it scroll, but the editor will still exactly fit on screen with the UI so this scrolling does not impact editing at all.

-Dan