Enlarge editor - Githubissues

cs136 / seashell

Seashell is an online environment for editing, running, and submitting C programming assignments.

GNU General Public License v3.0

38 stars 19 forks source link

Enlarge editor #654

Closed yuliswe closed 7 years ago

yuliswe commented 7 years ago

request #648

Shrink the padding of the entire webpage from 5em to 30px
Remove margin around the editor when the screen is smaller than 1440px in width
Clear up the editor size calculation code, remove window-resized event which is only used by this piece of code. Use css instead.
Editor is now 66% window height in vertical split mode, 70% window height in horizontal split mode

kpalway commented 7 years ago

I would prefer not to merge a change like this until after the frontend rewrite. Unless we have tested it in all supported browsers with different resolutions including the classroom projectors, and have some consensus among instructors that this is the interface they want.

yuliswe commented 7 years ago

Reverted resizing code. I'm going to make a separate PR for resizable UI. You need to merge this to fix issue #648

kpalway commented 7 years ago

Didn't the revert from earlier this week fix that issue? That was why we reverted it.

yuliswe commented 7 years ago

Olga Dan and I had further discussion about this after the meeting. I think this is what Dan wants.

kpalway commented 7 years ago

Okay, has it been tested it on the different browsers and on the projector?

yuliswe commented 7 years ago

I want to have this on staging for instructor feedback.

kpalway commented 7 years ago

Okay, make sure we test it thoroughly before our next release, I want to cut down on back and forth UI changes we've been having so far this term.

yuliswe commented 7 years ago

Sounds good! :D