search

cs136 / seashell

Seashell is an online environment for editing, running, and submitting C programming assignments.
GNU General Public License v3.0
38 stars 19 forks source link

Witchcraft error catching #716

Closed kpsuperplane closed 7 years ago

kpsuperplane commented 7 years ago

You might need to rewrite a lot of the error stuff to work with this..

e45lee commented 7 years ago

Can you merge origin react into your branch and repair the merge? Thanks.

yuliswe commented 7 years ago

Hi, can you make GenericError extend Error? Otherwise npm test / browsers will not show the stacktrace.

kpsuperplane commented 7 years ago

Doing so makes instance of not work. Not sure whu

e45lee commented 7 years ago

Try this: https://github.com/Microsoft/TypeScript/issues/13965

e45lee commented 7 years ago

@kpsuperplane Pull from e45lee/error-handling-fixes

e45lee commented 7 years ago

OK I'm going to merge your branch with the Error handling fixed so I'll close this for now.