search

cs233 / fliplot

HTML & JS based VCD viewer as a VS Code extension for CS 233
Apache License 2.0
0 stars 0 forks source link

Consider pulling in the vcd-parser into repo #2

Closed yufengwng closed 2 years ago

yufengwng commented 2 years ago

Currently, the vcd-parser is in another repo (cs233/vcd-parser), which is a bit of a hassle to work with, especially when you need to edit the code. The parser is really only just a single function within a single file. Perhaps we can just pull in the file in our src directory instead of having it as a dependency.

We'll want to respect copyright. Perhaps copy over their license as well into a LICENCE.vcd-parser file. And add plenty of acknowledges.

yufengwng commented 2 years ago

We originally intended to use the vcd parser forked from ahmed-agiza/vcd-parser but there was some bugs with it. I ended up porting over the original python parser we have in the projec to typescript instead, so we no longer need this lib.