search

cs3110 / textbook

The CS 3110 Textbook, "OCaml Programming: Correct + Efficient + Beautiful"
Other
720 stars 132 forks source link

Add nb_merge_streams config to coalesce stderr #121

Closed penelopeysm closed 1 year ago

penelopeysm commented 1 year ago

Hello! This is a small fix for the issue discussed in https://cs3110.github.io/textbook/chapters/data/lists.html about cell output being split into multiple output blocks. The upstream issue was fixed: executablebooks/jupyter-book#973, executablebooks/MyST-NB#364.

Before

Before HTML

After

After HTML
clarksmr commented 1 year ago

Thank you! I will merge this now, but it won't have an effect on the deployed textbook until we get around to #125 sometime in the future.

clarksmr commented 1 year ago

Ugh actually since merging it gets rid of the comment that explains the bad output, I'll have to revert the merge.

muzimuzhi commented 7 months ago

Ugh actually since merging it gets rid of the comment that explains the bad output, I'll have to revert the merge.

I'm confused. Adding nb_merge_streams: true solves the split stderr cell output, then the comment that explains the bad output is useless hence can be removed. Did I miss something?