Two things I noticed for the exercise "refactor arith":
The file algebra.ml contains six structures (3 Rings and 3 Fields), not four.
The Fraction functor only needs its input to be a Ring, not an entire Field. (This is also mathematically important, since the “field of fractions” construction is used to embed a ring into a field.)
Two things I noticed for the exercise "refactor arith":
Ring
s and 3Field
s), not four.Fraction
functor only needs its input to be aRing
, not an entireField
. (This is also mathematically important, since the “field of fractions” construction is used to embed a ring into a field.)