cs3110 / textbook

The CS 3110 Textbook, "OCaml Programming: Correct + Efficient + Beautiful"
Other
720 stars 132 forks source link

Issue on page /chapters/basics/compiling.html #80

Closed mjn298 closed 2 years ago

mjn298 commented 2 years ago

The current version of dune requires a file in the top-level directory (in this case, would just be ./hello-world) called dune-project with the following

(lang dune 3.0)

I think this file used to be automatically generated if absent, now it requires explicit creation.

jnfoster commented 2 years ago

@clarksmr can I leave this for you? Seems like we either want to pin the version, or freshen the install instructions.

clarksmr commented 2 years ago

Yes, this appears to be because Dune was at version 2 when the Fall 2021 version of the textbook was released, but now Dune is at version 3. I'll look into upgrading the textbook to use version 3.

clarksmr commented 2 years ago

4e36ad6 will fix this when published. That commit adds instructions for creating dune-project manually. Thanks!