search

cs340tabyu / cs340Winter2017

3 stars 0 forks source link

Player cannot login on different devices. #880

Open p-thak opened 7 years ago

p-thak commented 7 years ago

When logged in on multiple devices it overrides who was currently playing with the newest user and the first person logged in can't do anything including seeing new games and joining new games, just says authorization of request failed at the top. This occurs on different instances of the client on the same machine as well as on different machines.

ribsalad commented 7 years ago

This is the desired behavior, though, it should kick the user to the login screen. When a user signs in on a different device, we designed it to kick the current user. At this point any request is denied, but you should be able to leave the game, sign out, or leave the lobby. In your testing were you able to still leave the game/lobby or signout?

TODO: Joe add an error code to the error message on invalid login that the state monitors. If the error code says invalid login credentials, kick the client to the login screen to prevent confusion.

ribsalad commented 7 years ago

Would it be accurate to say the title is "Player cannot login on different devices and interact at the same time"?

p-thak commented 7 years ago

When you say "kick the current user" do you mean in the game? When in game, and the player logins on a different device, it does not boot the player out of the game, and when it is his turn, it does not allow the player to do anything. Basically it breaks the game when testing with 2,3 and 4 players. When in the lobby, the user can sign out on the first device, they are also able to open up the create window game, though it does not do anything after.

ribsalad commented 7 years ago

@p-thak Ah I see. Let me see if i understand: Player A on client 1 joins a game with N other people. Player A on client 2 then logs in. Nothing happens on client 2 and on client 1 the player can't do anything.

Is this correct? If so we haven't supported rejoining a game on a different client yet because we were under the impression persistence and being able to rejoin on the client is part of phase 4.

ribsalad commented 7 years ago

kicking user is implemented now so they get sent back to login screen.

Still need to support rejoining the game but that is Phase 4 stuff.