search

cs3org / OCM-API

OpenCloudMesh API
38 stars 11 forks source link

updating shares #36

Closed moscicki closed 1 month ago

moscicki commented 7 years ago

There is no way of updating shares — is this intentional?

dvh commented 7 years ago

@moscicki it is indeed intentional as the create call is a 'fire and forget' call. The receiving party might have removed the incoming share without notifying the sending party. This could be fixed by returning a 404 Not found or 410 Gone but then I wouldn't see the specific use of an update call. Updating the file (permissions) should be part of the specific protocol i.m.h.o. Updating the share itself could be intended to change the receiving user, name, description or the protocol itself, but once it already has been processed by the receiving party changing the user, name or description doesn't have any impact at all and changing the protocol would make things extremely complex.

I could add a PUT call the /shares/{id} quite easily, but I doubt if it offers a lot of added value.

michielbdejong commented 1 month ago

Related to #107. Closing as a question that was answered.