search

cs3org / cs3apis

:arrows_clockwise: Connect Storage and Application Providers
https://buf.build/cs3org-buf/cs3apis
Apache License 2.0
53 stars 28 forks source link

Share expiration #192

Closed C0rby closed 1 year ago

C0rby commented 1 year ago

Added changes to the API to support expiration on user and group shares.

labkode commented 1 year ago

@C0rby PR is good we just need to run the CI in the new infra, @micbar can you enable the cs3apis as well to run in ownCloud's drone?

micbar commented 1 year ago

@labkode @C0rby Done. But there is an issue, the pipeline needs a public key to publish the generated code.

@vascoguita How should we proceed?

vascoguita commented 1 year ago

@labkode @C0rby Done. But there is an issue, the pipeline needs a public key to publish the generated code.

@vascoguita How should we proceed?

I'm looking into it. Ideally, there would be no SSH key at all, specially in a PR-triggered workflow. Anyone could get the private key by making a PR with echo $SSH_KEY in the .drone.yml file.

I'll try to migrate this workflow to GH actions this afternoon. If there is urgency, we could generate a new key-pair

micbar commented 1 year ago

@vascoguita Thank you for the quick reaction. Afternoon sounds good 😄