search

cs3org / cs3apis

:arrows_clockwise: Connect Storage and Application Providers
https://buf.build/cs3org-buf/cs3apis
Apache License 2.0
53 stars 29 forks source link

align owncloud master against main #214

Closed dragonchaser closed 1 year ago

glpatcern commented 1 year ago

@diocas how did we implement hiding of shares in CERNBox without this?

micbar commented 1 year ago

@glpatcern

As I understand it, it is a CERN feature request to have two flags on each share

1) Accepted 2) Hidden

micbar commented 1 year ago

We already implemented it on the backend and the web client for the CERN merge.

glpatcern commented 1 year ago

@micbar not sure the two flags were understood to be independent, i.e. with the 4 combinations being meaningful. Anyway even assuming so, that still concerns the ReceivedShare, not the Share, right?

micbar commented 1 year ago

User story https://github.com/owncloud/web/issues/9531

glpatcern commented 1 year ago

Thanks, understood. I see the idea is also to observe adoption of those combinations and potentially simplify in the future.

With that, I think it's fine to add a hidden bool field to the ReceivedShare, next to (and indeed independent from) state. The Share structure/message should not be affected instead. Or do I miss something else?

dragonchaser commented 1 year ago

I will move it to ReceivedShare then.... I have set the PR to Draft for now, I want to make the necessary changes to reva/edge and merge it at the same time to avoid larger breakage.

dragonchaser commented 1 year ago

We have a PR for edge: https://github.com/cs3org/reva/pull/4256

dragonchaser commented 1 year ago

@glpatcern if you want you can merge it :)