cs3org / ocm-test-suite

Test suites for protocols a Personal Data Store may support
https://pdsinterop.org/test-suites/
MIT License
0 stars 8 forks source link

name=%9D%A9%9E #42

Closed michielbdejong closed 3 years ago

michielbdejong commented 3 years ago

reva pkg/ocm/share/manager/json/json.go line 198:

func (m *mgr) Share(ctx context.Context, md *provider.ResourceId, g *ocm.ShareGrant, name string,
    pi *ocmprovider.ProviderInfo, pm string, owner *userpb.UserId, token string, st ocm.Share_ShareType) (*ocm.Share, error) {

reva internal/grpc/services/ocmcore/ocmcore.go line 183:

share, err := s.sm.Share(ctx, resource, grant, req.Name, nil, "", req.Owner, token, shareType)

https://github.com/cs3org/cs3apis/blob/33ae0f73ede1a87d10d338218661c08f87d87954/cs3/ocm/core/v1beta1/ocm_core_api.proto#L64-L66

when coming in over http:

reva internal/http/services/ocmd/shares.go line 164:

        Name:       resource,

reva internal/http/services/ocmd/shares.go line 64:

resource, providerID, owner := r.FormValue("name"), r.FormValue("providerId"), r.FormValue("owner")

from our side:

reva internal/grpc/services/ocmshareprovider/ocmshareprovider.go line 165:

share, err := s.sm.Share(ctx, req.ResourceId, req.Grant, name, req.RecipientMeshProvider, permissions, nil, "", sharetype)

reva internal/grpc/services/ocmshareprovider/ocmshareprovider.go line 131-146:

var name string
    nameOpaque, ok := req.Opaque.Map["name"]
    if !ok {
        return &ocm.CreateOCMShareResponse{
            Status: status.NewInternal(ctx, errtypes.BadRequest("resource name not set"), ""),
        }, nil
    }
    switch nameOpaque.Decoder {
    case "plain":
        name = string(nameOpaque.Value)
    default:
        err := errtypes.NotSupported("opaque entry decoder not recognized: " + nameOpaque.Decoder)
        return &ocm.CreateOCMShareResponse{
            Status: status.NewInternal(ctx, err, "invalid opaque entry decoder"),
        }, nil
    }   

And in our reva-client here: https://github.com/cs3org/ocm-test-suite/blob/dev/reva-client.ts#L252-L255