search

cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
167 stars 113 forks source link

Riva overwrite content directory #1032

Open JarCz opened 4 years ago

JarCz commented 4 years ago

If I'm upload file to root path "/" Reva overwrite user content directory with single file. User lost all data.

Steps to reproduce:

cd reva/cmd/reva
echo "Test" >test.txt
./reva --insecure login basic
./reva --insecure upload test.txt /

after this operation directory "/var/tmp/reva/data" has only file "einstein", not directory "einstein"

labkode commented 4 years ago

@JarCz thanks for reporting this. We'll look into it.

glpatcern commented 4 years ago

Still seen today testing federated shares, reproduced on a local folder.

glpatcern commented 4 years ago

@ishank011 had actually reverted the fix, because it breaks the sync clients (one needs to be able to upload a file to a folder, not within it, from a sync client perspective). The solution is discussed at https://github.com/sciencemesh/sciencemesh/issues/108#issuecomment-691123077 and it is to change the reva CLI only, not the server side.