EOS GRPC doesn't populate the sys ACL field

cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends

https://reva.link

Apache License 2.0

167 stars 113 forks source link

EOS GRPC doesn't populate the sys ACL field #2246

Open ishank011 opened 2 years ago

ishank011 commented 2 years ago

We need something like https://github.com/cs3org/reva/blob/80f5ec9b8978bd659459a0db6db6ea9778119169/pkg/eosclient/eosbinary/eosbinary.go#L1089-L1092

ffurano commented 2 years ago

Having a look

ffurano commented 2 years ago

So, it seems to me that you want the ACL field to contain the content of the xattr field "sys.acl" in addition to the "real" ACLs that are returned by EOS/grpc (if any) Easy to do, yet since this seems strange to me, could you please confirm that I understood right?

ishank011 commented 2 years ago

Aren't these the "real" ACLs? Using file info you only get this

ffurano commented 2 years ago

I am not able to catch the subtlety that may lie between this xattr and the response of getacl. Surely if Insert the xattr we save one latency hit. However I got the message, and it's what I have done

I can't test it by now on eoshomecanary as my key has been removed. Since it's simple stuff, I am opening a MR anyway