cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
167 stars 113 forks source link

Spaces registry: path templates don't obey mountpoints #2843

Open ishank011 opened 2 years ago

ishank011 commented 2 years ago

For a storageprovider mounted at /users/[l-z]

https://github.com/cs3org/reva/blob/bdbc57ff6f1d9c1ffc8303045d8fcf0b7fb3031e/pkg/storage/registry/spaces/spaces_test.go#L216-L223

it's expected that a space with path /users/Alice would be returned

https://github.com/cs3org/reva/blob/bdbc57ff6f1d9c1ffc8303045d8fcf0b7fb3031e/pkg/storage/registry/spaces/spaces_test.go#L339-L353

@micbar @butonic

butonic commented 2 years ago

umm /users/[l-z] does not make sense for a user with username Alice, does it? If you mean that a storageprovider with the mount_point /users/[a-k] should return a space path /users/Alice, then I agree.

ishank011 commented 2 years ago

umm /users/[l-z] does not make sense for a user with username Alice, does it?

Exactly what I'm saying. If alice sends a ListStorageProviders request with a resourceID filter corresponding to a personal storage provider mounted at /users/[l-z], it should return a not found error. Currently it just frames the path depending on the user sending the request irrespective of whether the path would actually exist on the provider or not.