cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
167 stars 113 forks source link

CERN: File search #2970

Open labkode opened 2 years ago

labkode commented 2 years ago

Allow our users to search for filenames Provide a list of "recently viewed" files in the main UI

labkode commented 2 years ago

It should be there.

@dragotin @micbar how this search feature has been stress tested? How many files? Does the UI contains the "Recently viewed" files?

micbar commented 2 years ago

We implemented a bleve search index in ocis outside of reva which answers REPORT requests. It was not yet stress tested. We will test this before GA, that is sure.

I doubt that CernBOX can be treated as any other ownCloud out there ;-) So I expect a different CERN specific implementation. We implemented search using the same pattern using a SearchProvider and a SearchDriver. The Driver can be different and not use bleve.

dragotin commented 2 years ago

Hm, I would not give up on the bleve solution too fast. At least for personal spaces, that can be a proper solution. Others depend on the size of the indexed spaces.

labkode commented 2 years ago

@micbar can you point me to the interface that needs to be implemented?

micbar commented 2 years ago

https://github.com/owncloud/ocis/blob/3a43daf8c4a0b5580d953f88372b68aded5aa46a/extensions/search/pkg/search/search.go#L38

micbar commented 2 years ago

Current State

What would we need to do to scale that?

Understand the limitations of bleve

labkode commented 2 years ago

Work in progress, Bleve stress tests to be done.

labkode commented 2 years ago

We'll implement on master using the existing search API (Report method). The big chunk of work is in the driver, so by using the same interface as in edge, the migration should not give any major headaches.