cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
171 stars 112 forks source link

composer 2.3.9 needed in CI #3069

Open phil-davis opened 2 years ago

phil-davis commented 2 years ago

registry.cern.ch/docker.io/owncloudci/php:7.4 has composer 2.0.6

The recent release of bamarni/composer-bin-plugin https://github.com/bamarni/composer-bin-plugin/releases/tag/1.7.0 needs a later version of composer - something recent in the 2.3.* releases.

+ composer self-update
Upgrading to version 2.3.9 (stable channel).

Use composer self-update --rollback to return to version 2.0.6
+ composer --version
Composer version 2.3.9 2022-07-05 16:52:11

The reva CI in both master and edge branches has had the above added to do composer self-update at run-time. But it would be nicer if the docker image is updated with a more recent composer.

phil-davis commented 2 years ago

@labkode who manages the docker images at registry.cern.ch/docker.io/

(or do they automatically update when the owncloudci/php images are published?)

labkode commented 2 years ago

@phil-davis I think we pull from upstream but we use a docker proxy to avoid network throttling. @SamuAlfageme can you please check if this applies?

phil-davis commented 2 years ago

Note: I updated https://github.com/owncloud-ci/php/ this morning so that those PHP docker images now have composer 2.3.9

phil-davis commented 2 years ago

Note: bamarni/composer-bin-plugin 1.8.0 refactored their code so that it works with any composer 2.* version, and does not depend on new features in composer 2.3. So this is not a big problem any more. There is no big rush to sort it out.

phil-davis commented 2 years ago

A CI run just now: https://drone.cernbox.cern.ch/cs3org/reva/8095/17/7

+ cd /drone/src/tmp/testrunner
+ composer self-update
Upgrading to version 2.3.10 (stable channel).

Use composer self-update --rollback to return to version 2.0.6
+ composer --version
Composer version 2.3.10 2022-07-13 15:48:23

The PHP docker image still has composer 2.0.6. So it looks like it is not automatically updating from owncloudci/php