search

cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
167 stars 113 forks source link

Makefile depends on bash #3773

Closed michielbdejong closed 1 year ago

michielbdejong commented 1 year ago

Since https://github.com/cs3org/reva/commit/0374913e39e043a1af7bf10179911531c3c191b6 it is no longer possible to build revad on Ubuntu, because it uses dash instead of bash as the shell, which doesn't support the [[ ... ]]] syntax.

michielbdejong commented 1 year ago

A workaround is to remove that first term from the build flags, so it becomes:

BUILD_FLAGS    = " -X main.gitCommit=$(GIT_COMMIT) -X main.version=$(VERSION) -X main.goVersion=$(GO_VERSION) -X main.buildDate=$(BUILD_DATE)"

That is what we will be using on our server, because we're not using the static linking feature there anyway.