search

cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
167 stars 113 forks source link

Create infra for end to end test (auth, storage, sharing, ...) #441

Open labkode opened 4 years ago

butonic commented 4 years ago

@labkode we are working on acceptance tests for phoenix on top of ocis. Would that cover this issue? We should try to collaborate ... maybe in light of the phoenix / grpc work?

labkode commented 4 years ago

@butonic definitely that will cover a good part of it. What do you have in mind for doing the acceptance test for Phoenix? How can we help you?

individual-it commented 4 years ago

currently we are working into two directions:

  1. running oC 10 API acceptance tests with ocis/reva - not all parts will run on reva but a big part should (webDav, sharing, etc)
  2. running phoenix tests with ocis-phoenix, as phoenix should work 100% with ocis, all tests should pass(TM)

in both cases the features are described in cucumber language, for the API tests PHP code executes the actions and checks the results and for the phoenix UI tests JS code does the same and uses selenium to control the browser

API (and UI tests for oC10) can be found here: https://github.com/owncloud/core/tree/master/tests/acceptance phoenix UI test can be found here: https://github.com/owncloud/phoenix/tree/master/tests/acceptance

in theory you could use both things to run tests in this repo, we would have to think about if and how to keep the test systems in sync

madsi1m commented 4 years ago

Both 1+2 together seems like the right way to go

individual-it commented 4 years ago

I will update this issue with a link as soon as we have POC currently I'm working on the API side, and next in list (ether for me or s.o. else of our team) is to look into the phoenix tests

individual-it commented 4 years ago

I forgot this issue, sorry. UI tests are run with phoenix & ocis in https://github.com/owncloud/phoenix (first implemented in https://github.com/owncloud/phoenix/pull/2914) oC 10 API tests run in https://github.com/owncloud/ocis-reva

I suggest to run the tests (or a subset) also in this repo to prevent bugs like https://github.com/cs3org/reva/pull/627 and the regression it introduced