search

cs3org / reva

WebDAV/gRPC/HTTP high performance server to link high level clients to storage backends
https://reva.link
Apache License 2.0
165 stars 113 forks source link

fix: quotes in content-disposition header #4748

Closed JammingBen closed 6 days ago

JammingBen commented 1 week ago

Replaces the quotes by actually encoding the filename in the dav Content-Disposition header. The value of the filename* parameter must not be surrounded by any quotes, but rather be encoded in the first place. See RFC-6266 for more details.

The quotes caused an issue where certain browsers would decode the quotes and falsely prepend them to the filename.

refs https://github.com/owncloud/web/issues/11031

JammingBen commented 1 week ago

@saw-jan Do you know if the CI is currently flaky? I can't get it green, there always some test(s) failing. They are located in copyFileFolder.feature, it's not always the same test though.

saw-jan commented 1 week ago

@saw-jan Do you know if the CI is currently flaky? I can't get it green, there always some test(s) failing. They are located in copyFileFolder.feature, it's not always the same test though.

tests with posix-fs were flaky previously. https://github.com/owncloud/ocis/issues/9340