search

cs3org / wopiserver

A vendor-neutral application gateway compatible with the WOPI specifications.
Apache License 2.0
52 stars 27 forks source link

business flow #102

Closed wkloucek closed 1 year ago

wkloucek commented 1 year ago

add support for the business flow when using the wopi proxy with office 365

glpatcern commented 1 year ago

Hi guys, this is an interesting development that matches what I asked Tobias in an ongoing ticket with ownCloud support. Will look into testing it as well.

(Yet technically I'd hide this bit inside the generateWopiSrc function)

wkloucek commented 1 year ago

(Yet technically I'd hide this bit inside the generateWopiSrc function)

This parameter is not part of the wopiSrc, so it should not go inside the generateWopiSrc function. Instead it's a parameter to the app (just as wopiSrc is)

glpatcern commented 1 year ago

This parameter is not part of the wopiSrc, so it should not go inside the generateWopiSrc function. Instead it's a parameter to the app (just as wopiSrc is)

(Sure, one could rescope the function - at the same time generateWopiSrc is used in several places, so it can't be modified as is, that is clear. My point was simply that it would be better to hide those details)

BTW I'm trying out a variant of this in response to some ongoing investigations with Microsoft, and surprisingly the login to the Microsoft cloud does not get triggered. Does it for you @wkloucek ?

wkloucek commented 1 year ago

closing in favor of https://github.com/cs3org/wopiserver/pull/105