cs3org / wopiserver

A vendor-neutral application gateway compatible with the WOPI specifications.
Apache License 2.0
55 stars 26 forks source link

Added configuration flag to enable the business flow #105

Closed glpatcern closed 1 year ago

glpatcern commented 1 year ago

This is actually a variant that supersedes https://github.com/cs3org/wopiserver/pull/102

The goal is to make the business flow dependent on the config flag only, not on whether the app is proxied or not, and to leave it out on public shares.

(And I gave up in hiding the technical details from the main wopiserver.py class)

xoxys commented 1 year ago

@glpatcern Can you give a short hint how to use it? Just setting businessflow = True doesn't change anything in our setup, users can still edit documents in O365 without a login.

glpatcern commented 1 year ago

Hi @xoxys, same here actually, and same with ownCloud 10 Enterprise as far as I understand - @tbsbdr may give you more details. It seems there's something to be configured on the Microsoft CSPP portal, we have reported it but so far we don't have a response.

glpatcern commented 1 year ago

Hi @xoxys and @tbsbdr, I've noticed this message posted in the private CSPP Yammer group, dated August 17th. This settles the question why the MS login is not triggered (any longer).

We have recently made changes to the WOPI Business User Flow. 

Users will no longer be required to provide their login information when the WOPI host is accessing
our test environment.

The update will also be deployed in our production environment in the coming weeks. 

This change in the business user flow in no way impacts our partners' current WOPI configurations
and no changes are required to your host.