search

cs3org / wopiserver

A vendor-neutral application gateway compatible with the WOPI specifications.
Apache License 2.0
55 stars 26 forks source link

Option to disable healthcheck logging #123

Closed xoxys closed 1 year ago

xoxys commented 1 year ago

With wopiserver v10 a new healthcheck was introduced in https://github.com/cs3org/wopiserver/pull/122 which causes a lot of noise. Can we have an option to disable logging for the healthcheck or move it to the debug level? IMO, creating a log entry for every single successful healthcheck call is not very helpful.

xoxys commented 1 year ago

Thanks!

glpatcern commented 1 year ago

No problem! You're welcome to contribute a patch in such cases ;-)

xoxys commented 1 year ago

Happy to do :) This issue was meant to be for discussion as it happens too often that people investigate into a PR which is getting rejected because the maintainers disagree on implementing it.

glpatcern commented 1 year ago

Fair enough, though this one is not an architectural change so not much contentious.

As I'm at it, I introduced this health check for the ScienceMesh deployments, as having the wopiserver "up and running" but unable to talk to Reva is basically a broken deployment.