Open glpatcern opened 1 month ago
Marking as ready for review given that the code is pretty much complete. Once the build passes, we can review and merge this change.
Remaining tasks:
yield
ed exceptions from readfile()
, now that the function can raise
them.Following https://github.com/cs3org/cs3-python-client/pull/8 we now pass the whole test suite:
$ pytest-3
============================== test session starts ===============================
platform linux -- Python 3.9.18, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
rootdir: /root/WOPI
collected 20 items
test/test_storageiface.py
.................... [100%]
Therefore this is ready to review.
This PR is to introduce the https://github.com/cs3org/cs3-python-client library contributed by @rawe0.
As part of this, some refactoring and simplification has taken place:
getxattr()
API, as well as the caching recently introduced, as the xattrs are always queried next to a stat call.versioninv
flag on stat, assuming it's always version invariant. Only xroot was able to make a distinction.readfile
that now raises an exception instead ofyield
ing it. Consequently dropped thepeek
logic.@micbar a heads-up about a larger-than-usual change. I will test this with the Microsoft WOPI validator prior to merge.