New model for the openinapp endpoint

cs3org / wopiserver

A vendor-neutral application gateway compatible with the WOPI specifications.

Apache License 2.0

55 stars 26 forks source link

New model for the openinapp endpoint #43

Closed glpatcern closed 3 years ago

glpatcern commented 3 years ago

Following cs3org/reva#1923, this PR provides the needed JSON encoding for the Reva AppProvider's wopi driver when using the /wopi/iop/openinapp endpoint.

The old /wopi/cbox/open is still backward compatible, and error handling has been unified such that:

On success, /openinapp returns a JSON and /open returns the URL payload as before
On errors, they both return an error string and an HTTP status code

The /wopi/bridge/open endpoint used by the old Reva for CodiMD also works similarly.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging a43b16797ae0618d4e1b7aae2042bb4aa58d10fb into 2974f4027bbc6d695580bbc7627b35bff6f5bb1d - view on LGTM.com

new alerts:

1 for Information exposure through an exception

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging a59dbfe0c40b473f6052d8040786c41f9e649be4 into 51f127f3dd581ed96856216fab9cad52d2a55775 - view on LGTM.com

new alerts:

1 for Information exposure through an exception

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging ae2bd774ca629a10d6445d164aa8c6d4fcefcdcb into 51f127f3dd581ed96856216fab9cad52d2a55775 - view on LGTM.com

fixed alerts:

1 for Information exposure through an exception

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging 1533bf697b1da0e50f8739a9ff144f33ad8752fc into 51f127f3dd581ed96856216fab9cad52d2a55775 - view on LGTM.com

fixed alerts:

1 for Information exposure through an exception