search

cs3org / wopiserver

A vendor-neutral application gateway compatible with the WOPI specifications.
Apache License 2.0
52 stars 27 forks source link

Wopiserver Cleared - Flake8 E501 and W503 ignored (Lint) #70

Closed osamaahmed17 closed 2 years ago

osamaahmed17 commented 2 years ago

Managed to clear the error by Flake8 for Wopiserver. Ignored the following error as they are for line length or deprecated E501: Line too long (82 > 79 characters) W503: Line break occurred before a binary operator. Check here for its deprecation (https://github.com/mila-iqia/cookiecutter-pyml/issues/10)

osamaahmed17 commented 2 years ago

I have cleared all the Lint issues in the Wopiserver Project. Was having a merge conflict which I cleared. Hopefully, it's ready to get merged after reviewing from @glpatcern. Do mention when it is ready to marked "Ready for review".

osamaahmed17 commented 2 years ago

While going through the code, these commits to the Master branch were added later. That's why it's showing a conflict, I guess.

glpatcern commented 2 years ago

Once fixed and merged, this closes #60: the linting so far is more than sufficient, as we got rid of some python 2 remainings. The line length is an open debate: GitHub is configured with 127 chars, we have further relaxed it to 130 chars and there are just a few lines longer than that, that's totally fine. Honestly I don't think that nowadays any developer uses 79 chars as a maximum line length.

osamaahmed17 commented 2 years ago

Once fixed and merged, this closes #60: the linting so far is more than sufficient, as we got rid of some python 2 remainings. The line length is an open debate: GitHub is configured with 127 chars, we have further relaxed it to 130 chars and there are just a few lines longer than that, that's totally fine. Honestly I don't think that nowadays any developer uses 79 chars as a maximum line length.

Yeah its still a mystery 😄

osamaahmed17 commented 2 years ago

Resolved conflicts. Have accepted all the changes from master in my branch.