Refactor logs around returning HTTP 409 responses to better understand MS Office 365 behavior

cs3org / wopiserver

A vendor-neutral application gateway compatible with the WOPI specifications.

Apache License 2.0

52 stars 27 forks source link

Refactor logs around returning HTTP 409 responses to better understand MS Office 365 behavior #77

Closed glpatcern closed 2 years ago

glpatcern commented 2 years ago

For the moment, this only adds logic and logging to validate whether the heuristic is correct, without taking any action.

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 8968e10e081a3f4ee64fbbf1711d16d9c0a8fc76 into d8aa2e25b1bd8f23e21b89fc7be00c215539e3a0 - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 5c76eb3b2de176b36bd48e292d5bb590b381353a into d8aa2e25b1bd8f23e21b89fc7be00c215539e3a0 - view on LGTM.com

new alerts:

1 for Variable defined multiple times

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert and fixes 1 when merging 7ff660acf4289d8c04852c41a28845b73ec4fb68 into d8aa2e25b1bd8f23e21b89fc7be00c215539e3a0 - view on LGTM.com

new alerts:

1 for Syntax error

fixed alerts:

1 for Reflected server-side cross-site scripting

glpatcern commented 2 years ago

Eventually the intended heuristic was proven not to work, as we have seen active sessions successfully saving the file (PutFile), and within 2-3 minutes another session with a conflicting lock being legitimately returned HTTP 409 and yet showing a failure to the user as opposed to acknowledging the existing lock and joining the shared collaborative session.

As such, this PR only includes some logs refactoring now, and will be merged as it does not introduce any behavioral change.