Closed kzidane closed 6 years ago
Oh I see makes sense.
On Fri, Oct 12, 2018 at 15:24 Kareem Zidane notifications@github.com wrote:
@kzidane commented on this pull request. In cs50/2018/fall/challenges/site/check50/init.py https://github.com/cs50/checks/pull/65#discussion_r224891659: @@ -0,0 +1,8 @@ +from check50 import * + + +class Site(Checks): + @check() def submitted(self): """site deployed to https://USERNAME.cs50.site""" @dmalan https://github.com/dmalan other checks seem to start with lowercase letter. Just wanted to keep consistent. Username is forced to lowercase here: - https://github.com/cs50/check/pull/17/files#diff-9749647d6f1a530a79f643b69fa1570dR12 https://github.com/cs50/check/pull/17/files#diff-9749647d6f1a530a79f643b69fa1570dR32 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cs50/checks/pull/65#discussion_r224891659, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwIxnppHIxwT4UEmyfLMEHRFGSg_VoTks5ukOx4gaJpZM4XZ9cb .
In cs50/2018/fall/challenges/site/check50/init.py https://github.com/cs50/checks/pull/65#discussion_r224891659:
@@ -0,0 +1,8 @@ +from check50 import * + + +class Site(Checks): + @check() def submitted(self): """site deployed to https://USERNAME.cs50.site"""
@@ -0,0 +1,8 @@ +from check50 import * + + +class Site(Checks): +
@dmalan https://github.com/dmalan other checks seem to start with lowercase letter. Just wanted to keep consistent. Username is forced to lowercase here:
https://github.com/cs50/check/pull/17/files#diff-9749647d6f1a530a79f643b69fa1570dR32
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/cs50/checks/pull/65#discussion_r224891659, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwIxnppHIxwT4UEmyfLMEHRFGSg_VoTks5ukOx4gaJpZM4XZ9cb .
Oh I see makes sense.
On Fri, Oct 12, 2018 at 15:24 Kareem Zidane notifications@github.com wrote: