search

cs50 / codespace

https://cs50.readthedocs.io/cs50/codespace
GNU General Public License v3.0
119 stars 351 forks source link

Adds Develop mode for update50 #139

Closed rongxin-liu closed 9 months ago

rongxin-liu commented 9 months ago

Running update50 --develop will automatically grab the devcontainer.json file from the develop branch and set the image tag to develop, which avoids having to manually update the .devcontainer.json file on Codespace during dev-testing.

dmalan commented 9 months ago

Sounds handy. Though feels like a lot of implementation details to put in update50.sh? Would it be cleaner to move the filtration to a URL like https://cs50.dev/devcontainer.json?develop, then only the URL needs to be conditional in update50.sh?

We could even generalize then where by the URL is more like https://cs50.dev/devcontainer.json?tag=develop and usage is like update50 -t develop?

rongxin-liu commented 9 months ago

Sounds handy. Though feels like a lot of implementation details to put in update50.sh? Would it be cleaner to move the filtration to a URL like https://cs50.dev/devcontainer.json?develop, then only the URL needs to be conditional in update50.sh?

We could even generalize then where by the URL is more like https://cs50.dev/devcontainer.json?tag=develop and usage is like update50 -t develop?

Good idea! I made this PR for cs50.dev: https://github.com/cs50/cs50.dev/pull/197