search

cs50 / lab50.vsix

Inspired by https://github.com/lostintangent/workspace-layout/
GNU General Public License v3.0
21 stars 4 forks source link

Does VS Code come with default CSS for pre/code blocks so that code blocks could potentially have some sort of rectangle or background color around them, without resorting to custom CSS? #22

Closed dmalan closed 2 years ago

dmalan commented 2 years ago
Screen Shot 2022-09-09 at 9 01 19 PM
rongxin-liu commented 2 years ago

https://github.com/cs50/lab50.vsix/issues/14

rongxin-liu commented 2 years ago

code blocks now have vscode style background (using editor color scheme):

Screen Shot 2022-09-10 at 21 21 23 Screen Shot 2022-09-10 at 21 21 19
dmalan commented 2 years ago

Would it be cleaner just to include all of https://github.com/microsoft/vscode-extension-samples/blob/main/webview-view-sample/media/vscode.css after all, rather than maintain excerpts in our lab50.css?

rongxin-liu commented 2 years ago

No, that's only a demo of showing how to use vscode's theme color. It doesn't even cover <code> <pre> tag styles and such.

rongxin-liu commented 2 years ago

So we only include vscode style that we need in our lab50.css, I think that's cleaner actually. I also made some tweaks to the button style because the one shown in the demo wasn't looking good.