search

cs50 / lab50.vsix

Inspired by https://github.com/lostintangent/workspace-layout/
GNU General Public License v3.0
21 stars 4 forks source link

Running "Open in CS50 Lab" command via command-shift-p yields error #28

Closed dmalan closed 2 years ago

dmalan commented 2 years ago
Screen Shot 2022-09-10 at 1 01 43 PM

Command 'Open in CS50 Lab' resulted in an error (Cannot read properties of undefined (reading 'path'))

Do we need for the command to appear in the palette at all, though, since the command alone wouldn't know which folder to open, unless we add a file dialog?

rongxin-liu commented 2 years ago

Ah, suppressed! https://github.com/cs50/lab50.vsix/commit/f887a94b9c4fb1eca0e7703a0c2295f9ed36a9f3

dmalan commented 2 years ago

Do we definitely need it in commandPalette at all?

rongxin-liu commented 2 years ago

We don't need it. But once we contribute a command, it will appear in the command pallet. If you look at our package.json file, we don't contribute anything to the command palette, yet the command still appears in the command pallet.

That's why we need another command pallet contribution to suppress it.

dmalan commented 2 years ago

Gotcha!