cs50 / lab50.vsix

Inspired by https://github.com/lostintangent/workspace-layout/
GNU General Public License v3.0
21 stars 4 forks source link

Could extension detect when running in VS Code desktop and render YouTube videos as links instead of iframes? #57

Closed dmalan closed 2 years ago

dmalan commented 2 years ago

Awesome, thanks! Just to make the UX a bit closer to Codespaces, should we perhaps embed an img instead with the video's thumbnail, https://stackoverflow.com/a/2068371, at a 16x9 aspect ratio? And when clicked, the image leads to the URL? We could additional overlay a "play" icon perhaps as a call to action?

rongxin-liu commented 2 years ago

This is how how the video tag would be rendered on VS Code locally:

Screen Shot 2022-09-28 at 09 35 27
dmalan commented 2 years ago

Is it possible to mimic YouTube's play icon identically, as by using the same img?

rongxin-liu commented 2 years ago

Yes we can:

Screen Shot 2022-09-28 at 10 17 27