cs50 / problems

Checks for check50
134 stars 227 forks source link

[pset4] [recover] Add hashes for jpeg files without trailing zeros #243

Open RCW679 opened 3 months ago

RCW679 commented 3 months ago

I wrote Recover from pset4 in such a way that it would actually parse the jpeg headers and look for EOI (FF D9), and stop there. This means that my implementation doesn't save the trailing zeros after EOI -- only to realize that the check50 checks failed with 'recovered image does not match', even though the actual content in the JPEG was the same. I then went to the checks and realized that it was using hashes of JPEG files with the trailing zeros. I then wrote a new Recover in such a way that it preserved the trailing zeros, and the checks passed.

The modifications in this PR add the hashes of the JPEG files without trailing zeros, while preserving the hashes of the JPEG files with the zeros.