search

cs50 / problems

Checks for check50
145 stars 237 forks source link

Allow rounding as well as truncating in `volume` #253

Open chriscarrollsmith opened 4 months ago

chriscarrollsmith commented 4 months ago

check50 cs50/problems/2024/x/volume returns failed tests if you use the round function after multiplying by the scaling factor. Rounding is arguably more correct than simply coercing the result back to an integer, which truncates the resulting number.

guyewhite commented 4 months ago

@yuliiazhukovetsHU Are you a pro at checks? I've actually never written one! I'd sure like to learn!

goyalyashpal commented 2 months ago

I think this issue can be closed per the merged request: