search

cs50 / problems

Checks for check50
134 stars 227 forks source link

fix: test for amount of functions inside test_jar.py file #254

Open iGoodw1n opened 2 months ago

iGoodw1n commented 2 months ago

There is a bug in test that checks number of functions in jar problem. Bug occurs when number of functions is more than nine because pattern matches only one digit. Now it will match all digits in passed tests.

guyewhite commented 2 months ago

@curiouskiwi @yuliiazhukovetsHU Are either of you experts at checks? I've never actually written one -- but would love to learn!

yuliiazhukovetsHU commented 1 month ago

Not an expert but happy to work on this together!

Yuliia

On Sun, Jul 7, 2024 at 9:01 PM Guy E. White @.***> wrote:

@curiouskiwi https://github.com/curiouskiwi @yuliiazhukovetsHU https://github.com/yuliiazhukovetsHU Are either of you experts at checks? I've never actually written one -- but would love to learn!

— Reply to this email directly, view it on GitHub https://github.com/cs50/problems/pull/254#issuecomment-2212706086, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCJODOBAARWRPOETHCH42TDZLHQGZAVCNFSM6AAAAABKPEJAYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSG4YDMMBYGY . You are receiving this because you were mentioned.Message ID: @.***>