shouldnt punish space after function

goyalyashpal commented 2 years ago

Summary

style50 shouldnt punish the space used between function and the bracket for arguments

Details:

I am open to knowing what the experienced people think about it. But in my humble opinion:
The space between function name and () helps a lot when there are lots of arguments, or argument immediately has lots of symbols
It is suggested for standard functions like while (), if (), for () etc.
.... even in the cs50 styling guide as well: https://cs50.readthedocs.io/style/c/#conditions
I get that style50 should not suggest/enforce spaces, but it should not punish them either.

Further Screenshots:

Small image
Large
- /!\ spoiler alert /!\ : can contain solution code
- shown in thin rectangle is the space used with standard functions
- image

Environment:

style50 --version : 2.7.5
ide c9 --version : 3.1.3534 ( https://ide.cs50.io )

duplicate 🔍 : space after function

dmalan commented 2 years ago

Most style guides do not prescribe a space between a function's name and opening parentheses, I'm afraid, CS50's among them!

goyalyashpal commented 2 years ago

do not prescribe a space between a function's name and opening parentheses

for functions other than if, for, while ; right?

goyalyashpal commented 2 years ago

update: i agree it's better to not have space b/w function name & opening parenthesis. there're some whitespace-sensitive languages like julia which do not allow this kind of space and treat it as syntax error.

syntax: space before "(" not allowed in "println (" at ...

and so, i have just settled on space inside the parenthesis for my own style. so: function( "string", argument2 )

cs50 / style50