search

cs96and / FoundryVTT-damage-log

FoundryVTT module to report all damage and healing to a separate chat tab
MIT License
9 stars 9 forks source link

Incompatibility with DF Chat Enhancements chat merge #28

Closed Talutha closed 1 year ago

Talutha commented 1 year ago

When using this module with DF Chat Enhancements, the messages don't merge as expected until a client reload. I believe this worked before v10 but does not anymore. If I disable use separate damage tab, the behavior is as expected with the messages merging correctly. I'm not sure if this is something you want to handle and I only bring it up because it seems like you've specifically fixed it in the past. Thank you for any help you can offer :).

I have tested this with the Pathfinder 2e system with only DFCE, it's dependencies and Damage Log enabled as a GM.

cs96and commented 1 year ago

Can you provide a screenshot of the problem please?

Talutha commented 1 year ago

Sure thing!

chrome_qGcPc1TgKI

This is styled with Dorako's PF2 UI but the behavior is the same without it. The top strike card is combined with the damage card as expected. The bottom two cards are not combined. On a reload of the page, the bottom two cards will be combined as expected.

Here are the same cards AFTER a reload:

chrome_ZEYheOxHGI

Disabling Damage Log or turning off the damage tab resolves the issue.

cs96and commented 1 year ago

This needs a change in DF Chat Enhancements. I know what needs to be fixed, so I'll raise an issue on that module.