search

cs96and / FoundryVTT-damage-log

FoundryVTT module to report all damage and healing to a separate chat tab
MIT License
9 stars 9 forks source link

Issues with hiding max HP from players #47

Closed ChobitsCrazy closed 2 months ago

ChobitsCrazy commented 3 months ago

Testing on: Foundry: v11.315 D&D: 3.1.2 Damage Log: 1.21.0 -No conflicting modules Settings: image

This is the player view result: image

Expectation: To not show the maximum/current HP for the creature.

ChobitsCrazy commented 3 months ago

Nevermind I determined how this interacts with the "Minimum actor permission" setting. However may want to make a note somewhere on the "Show limited damage..." setting that this is overridden by the "Minimum actor permission" setting.

cs96and commented 3 months ago

It's not supposed to look like that. With dnd5e v3, it should look like this... image

Have you tried disabling all other modules? Do you have some other module enabled that adds portraits to messages (e.g. Simply Portraits or Chat Portrait). Note that portrait providing modules are no longer required with dnd5e v3 as the system now takes care of adding the portraits.

ChobitsCrazy commented 3 months ago

Yes the only modules enabled is this mod, the screenshots are from my test environment where I run the bare minimum. I do not have either of those mods installed.

cs96and commented 2 months ago

I'm still not seeing this issue. Both the the DM view and player view look fine to me. Can you please double check if you have any other modules enabled (apart from libWrapper)?

ChobitsCrazy commented 2 months ago

Okay I tested on a brand new world and didn't have the issue so I circled back to my main world and double checked. Turns out for the first time ever Module Management+ is conflicting with something (a module I normally exclude since it does so little).

cs96and commented 2 months ago

Thanks for checking again. As Module Management+ looks deprecated, I will close this issue.

ChobitsCrazy commented 2 months ago

Thanks for checking again. As Module Management+ looks deprecated, I will close this issue.

Where does it say that? Works just fine for me? It's also included in the MIDI-Verse and verified working for v12 and DnD3.2

cs96and commented 2 months ago

ModuleManagement+ has not had any commits for over a year, and no issues have been fixed in that time either, so it looks abandoned. https://github.com/mouse0270/module-credits