search

cs96and / FoundryVTT-damage-log

FoundryVTT module to report all damage and healing to a separate chat tab
MIT License
9 stars 9 forks source link

Undo of damage to actor with initially negative HP #5

Closed skepickle closed 3 years ago

skepickle commented 3 years ago

Foundry Virtual Tabletop version 0.8.8 System: 3.5 SRD version 0.94.5 Damage Log version 1.1.0 So here's a situation. Actor has -14 HP initially. I apply 1 dmg, taking it down to -15 HP. Then undo that damage using right-click on Damage Log entry. The actor now has 0 HP. Here's a screenshot that I believe captures the situation: negHPbug

cs96and commented 3 years ago

I am unfamiliar with D&D 3.5. What does negative HP mean?

Anyway, Damage Log currently prevents you reducing HP past zero. Should be easy enough to fix.

skepickle commented 3 years ago

Negative HP in 3.5e is not really different from positive HP. In 3.5e there is a negative HP threshold at which things actually die. There's no "Death Saving Throws" in 3.5e. Anyways... In my imagination, undoing damage should be agnostic to this right? It should just go back to the previous HP value if I undo the damage.

And this is not a super-higher-priority issue. Just thought I'd point it out. :-)

cs96and commented 3 years ago

I've been playing with the D&D v3.5 system, and I noticed that it is actually possible to reduce the HP of an actor below its minimum value. E.g. the min HP for an Ape is -100, but you can reduce it to e.g. -200 if you wanted to. I think this is a bug in the 3.5 system, but am happy to be corrected, because as I said, I don't know anything about v3.5.

Damage Log will try to cap values to the min and max values when reverting/redoing damage. Should I continue to cap to the minimum value for 3.5? Or should I allow it to go below that?

cs96and commented 3 years ago

Looks to be the same in PF1 as well.

cs96and commented 3 years ago

537c441831760292ec961c58fa1ca855b61ed2e4

cs96and commented 3 years ago

Fixed in v1.2.0