search

csMACnz / coveralls.net

Coveralls uploader for .Net Code coverage
MIT License
87 stars 27 forks source link

upgrade to dotnet5 #103

Closed johanhugg closed 3 years ago

johanhugg commented 3 years ago

Quite ugly code but didn't really find a better way to do it..

This change is Reviewable

johanhugg commented 3 years ago

Not sure about the appveyor stuff :)

csMACnz commented 3 years ago

Thanks for the contribution @johanhugg . I'm in the middle of moving onto trunk-based development, so will make this upgrade the first thing i do to test that out. :+1: 🦖

csMACnz commented 3 years ago

Looks like an issue with both me configuring a fixed version of appveyor, and appveyor not supporting the RTM of .Net 5 yet.

csMACnz commented 3 years ago

Sorry that wasn't an intentional close, I deleted the develop branch after merging all outstanding changes to master. I can either cherrypick this into a new PR or feel free to open another against master if you prefer.