search

csaboka / spacechempatch

SpaceChem Modding Tool
MIT License
5 stars 1 forks source link

New patch: show reactor priority #18

Closed csaboka closed 6 years ago

csaboka commented 6 years ago

I'd like to get an extra set of eyes on this patch before merging into master. It seems to do what it's supposed to, but since I'm not very familiar with the cases where you want to know the priority of a reactor, I'd like a more experienced player to try it out.

Also, now it's showing the priority of anything that can take or output molecules because I assume you might care about the priorities of the fixed elements. Let me know if it should be limited to reactors only.

12345ieee commented 6 years ago

I've pushed to the branch 2 more commits. The first undoes your patch, leaving only decoys.

The second adds my patch, which does exactly the same thing as yours, but 1 level over in the calling hierarchy, so that we can run the loop only once.

If everything works well, you may want to squash the 3 patches commits together.

12345ieee commented 6 years ago

Pushed 2 more trivial changes. They should both be squashed in the respective commits.

With this, I approve the final version. When you have time, take a look @csaboka .

csaboka commented 6 years ago

Merged. Thank you for the extra effort you've spent to make this patch elegant!